Further optimise BuildAllDependsAndPaths() - #10312
Open
vaisest wants to merge 3 commits into
Open
Conversation
vaisest
commented
Aug 30, 2026
| if not hoverNode.path then | ||
| -- Mastery nodes cannot be traced through as they are allocated through | ||
| -- a popup, and cannot be pathed out of | ||
| if hoverNode and hoverNode.type ~= "Mastery" then |
Contributor
Author
There was a problem hiding this comment.
This also fixes a crash when a mastery node is on the trace path
vaisest
added
technical
vaisest
changed the title
Contributor
|
Reproduced on
Enregistrement.2026-08-30.124944.mp4AI-assisted review disclosure: This finding was identified during a review using OpenAI Codex and confirmed with a focused manual reproduction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This further optimises
BuildAllDependsAndPaths()a tiny bit. In my totally realistic synthetic benchmark it made it about 1 ms faster (5.6 -> 4.6). This is done by sorting path neighbours so that theFindStartFromNode()does less work on average, and by changing the node path from an array of the whole path, to just linking to a parent node.Steps taken to verify a working solution:
Link to a build that showcases this PR:
Build used for testing: https://poe.ninja/poe1/pob/98d8f